-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utilities for computing aggregate reports #12
base: v0.1.1
Are you sure you want to change the base?
Conversation
@JacobVanGeffen can you pull |
It's up to date, CI is breaking b/c there are warnings from unused things in the example. Will remove/use those things in the next commit. |
1f5c7a0
to
031d562
Compare
84256ee
to
2d1f908
Compare
e603694
to
0218ceb
Compare
7006302
to
bb80bc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still aggregating over all lines? If so, this isn't super usable because there are a LOT of lines. Users will typically e interested in 4 or 5 spots to aggregate...maybe 10 at the most. This will give them 100s of lines, and this will take way way way too long to run.
/// that was solved using the same `config` that was passed into `init_root`. | ||
/// | ||
/// [`update_report_for_game`]: #method.update_report_for_game | ||
pub fn init_root(lines: Vec<Vec<Action>>, config: TreeConfig) -> Result<Self, String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkushigian This is the initialization function for AggActtionTree
. It takes the set of lines that the aggregation report should run over, and constructs the tree (w/o any data) for only those lines. Then, when update_report_for_game
is called, only data relevant for those lines is stored.
93d560e
to
4b4f246
Compare
This PR adds the following features:
49N
rows, whereN = # of flops
(all with same statistics as flop aggregate report)49*48N
rows, whereN = # of flops
Tasks